This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Merged
Conversation
t2h5
force-pushed
the
features/company
branch
from
0f7c6ff to
14c5d90
Compare
t2h5
commented
Nov 11, 2022
Contributor
Author
t2h5
left a comment
t2h5
left a comment
There was a problem hiding this comment.
第2引数に COMPANY を指定して企業情報を取得できるようにしました
akiomik
reviewed
Nov 11, 2022
akiomik
reviewed
Nov 11, 2022
| jest.clearAllMocks() | ||
| }) | ||
|
|
||
| test('get', () => { |
Contributor
There was a problem hiding this comment.
すみません、 get と put のテストも一応書いてもらえると！
quarterやdailyにテストが存在してないのは追加し忘れか手抜きだと思います… 🙇
大元は getXXX と putXXX しかなくて、 get と put は後から追加したものです。
getXXX や putXXX は移行のためにpublicなメソッドになってますが、おそらく使ってるところはもうないため、順次privateに切り替えていって、 get と put だけテストする世界線にした方がわかりやすいかなと。
akiomik
reviewed
Nov 11, 2022
Co-authored-by: Akiomi Kamakura <akiomik@gmail.com>
akiomik
reviewed
Nov 11, 2022
akiomik
reviewed
Nov 11, 2022
akiomik
reviewed
Nov 11, 2022
Contributor
akiomik
left a comment
akiomik
left a comment
There was a problem hiding this comment.
コメントしました。メインの処理は良さそうでした 👍
akiomik
reviewed
Nov 11, 2022
| static readonly defaultOndemandApiEnabled = false | ||
| static readonly defaultOndemandApiCallMode = Setting.ondemandApiCallModes.DEFAULT | ||
|
|
||
| static readonly companyIntent = 'COMPANY' |
Contributor
|
第2引数をなんて呼ぶか だけ決めてしまいたいな |
shoe116
approved these changes
Nov 11, 2022
Contributor
shoe116
left a comment
shoe116
left a comment
There was a problem hiding this comment.
intent で合意取れたので intent で！
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.