Saving Promise breaks "What It Means for Canadians"

[melkuo]

Describe the bug
When you save a progress in admin, "What it means for Canadians" section breaks. This is presumably due to how we're handling commas.

Example of a broken one: https://www.buildcanada.com/tracker/innovation-science-and-economic-development-canada/promises/183

[maxnorm]

I'm currently looking at this issue.

It's mainly caused by the mismatch between the avo field (textarea) vs the db schema (array). When saving in the admin, an auto conversion is made based on commas.

I made a fix on a fork. I created a virtual attribute for formatting and parsing the input from the admin. This is the lowest-impact fix, since we keep the textarea with the current array format.

in admin after submit:

in postman after submit:

We can also check to change this field as an array within avo. https://docs.avohq.io/3.0/fields/array.html

I'm testing a bit more but i should submit a PR soon. (mostly tomorrow)

Fix:

# app/avo/resources/promise.rb

field :what_it_means_for_canadians_for_avo, as: :textarea, name: "What it means for Canadians"

# app/models/promise.rb

  # Virtual attribute for Avo admin interface
  def what_it_means_for_canadians_for_avo
    what_it_means_for_canadians&.inspect || "[]"
  end

  # Handle array format for Avo admin interface
  def what_it_means_for_canadians_for_avo=(value)
    if value.is_a?(String)
      if value.strip.start_with?("[") && value.strip.end_with?("]")
        begin
          parsed = JSON.parse(value)
          self.what_it_means_for_canadians = parsed if parsed.is_a?(Array)
        rescue JSON::ParserError => e
          Rails.logger.warn("Failed to parse array format: #{e.message}")
        end
      else
        Rails.logger.warn("Expected array format but got: #{value}")
      end
    else
      self.what_it_means_for_canadians = value
    end
  end

[maxnorm]

I think we can close this one