Bundle the hashes to prevent 404s #113
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Angular build configuration to use bundle-specific hashing instead of hashing all files, aimed at preventing 404 errors during deployment. The changes update both the local build configuration and the CI/CD deployment workflow.
- Changed output hashing strategy from "all" to "bundles" in Angular configuration
- Updated GitHub Actions workflow to use
npm cifor more reliable dependency installation - Added explicit output hashing parameter to the build command in CI/CD
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| angular.json | Modified outputHashing setting from "all" to "bundles" for production builds |
| .github/workflows/deploy.yml | Updated to use npm ci and added explicit output-hashing flag to build command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| ], | ||
| "outputHashing": "all" | ||
| "outputHashing": "bundles" |
There was a problem hiding this comment.
Changing from 'all' to 'bundles' reduces cache busting effectiveness. While this may resolve 404s, it means that changes to individual files within bundles won't trigger cache invalidation, potentially serving stale content to users. Consider if the root cause of 404s can be addressed through proper server configuration instead.
| "outputHashing": "bundles" | |
| "outputHashing": "all" |
* Add dependabot config (#110) * add dependabot config * code cleanup * update precommit * ci: bump the actions-deps group with 3 updates (#111) Bumps the actions-deps group with 3 updates: [actions/checkout](https://github.com/actions/checkout), [actions/setup-node](https://github.com/actions/setup-node) and [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action). Updates `actions/checkout` from 3 to 5 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v5) Updates `actions/setup-node` from 3 to 5 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v5) Updates `JamesIves/github-pages-deploy-action` from 4.6.4 to 4.7.3 - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.6.4...v4.7.3) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: JamesIves/github-pages-deploy-action dependency-version: 4.7.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bundle the hashes to prevent 404s (#113) * bundle the hashes * Update .github/workflows/deploy.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.