Update fork #1
Open
Update fork #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
task/add_namespace
Ios build error fix
task/add_namespace
This PR improves the `getFileName` function to properly handle situations where multiple files with the same name are shared. The enhancement ensures unique filenames by appending a counter to duplicate names. Changes made: - Modified the `getFileName` function to use a `fileNameCounter` dictionary to track filename occurrences - Implemented logic to append a counter to filenames when duplicates are detected Key improvements: - Prevents overwriting of files with the same name - Maintains the original file extension - Generates unique filenames by appending a counter (e.g., "file_1.jpg", "file_2.jpg") Testing: - Verified the function generates unique names for files with identical names - Tested with various file types and naming scenarios This change resolves issues related to handling multiple shared files with the same filename, ensuring each shared file is saved with a unique name.
- Modify handleIntent function to allow sharing both URL and files in the same intent - Update text extraction logic to handle both ACTION_SEND and ACTION_VIEW intents - Ensure attachments and text content are properly processed together - Improve overall flexibility of shared content handling
Quick fix to resolve: The caller of UIApplication.openURL(_:) needs to migrate to the non-deprecated UIApplication.open(_:options:completionHandler:). Force returning false (NO).
… migrate to the non-deprecated UIApplication.open(:options:completionHandler:). Force returning false (NO).
Bump compileSdkVersion to 34
Fix getFileName function to handle duplicate filenames
fix: UIApplication.openURL is deprecated
Fix sharing not working on iOS 18
ACTION_VIEW is not meant for sharing: it's meant for deep links. The documentation for receiving share intents [1] only mentions ACTION_SEND and ACTION_SEND_MULTIPLE. share_handler should only handle share intents, to avoid conflicts with other packages handling deep links (e.g. app_links). [1]: https://developer.android.com/training/sharing/receive Closes: #86
Starting app from 'recent applications' starts it with the last intent
Remove Intent.ACTION_VIEW handling
Upgrade Android dependencies and tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.