Implement arbitrary for CString#257
Closed
ThomasdenH wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Is this PR acceptable? Should I change anything? |
Contributor
|
@BurntSushi seems to keep pretty busy. He maintains quite a few libraries (just look at his github!). He takes a while to get around to reviewing PRs, but he often does eventually. Mentioning him with @ (as I already did) sometimes helps. I can give you a comment in the meantime though. I'm not convinced of the need for your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #165. This implementation builds a
CStringfrom either aStringor aVec<u8>. It shrinks using theVecShrinker, everywhere making sure no null characters end up in theCString.To prevent using as many allocations, it is built using an iterator, which is then filtered directly. I can change that if it's undesirable.