Implement Arbitrary for fixed-sized arrays of Arbitrary elements#289
Closed
nicoonoclaste wants to merge 1 commit into
Closed
Implement Arbitrary for fixed-sized arrays of Arbitrary elements#289nicoonoclaste wants to merge 1 commit into
nicoonoclaste wants to merge 1 commit into
Conversation
4 tasks
Owner
|
This looks like a duplicate of #282. |
Author
|
@BurntSushi Oops, yes, I missed that there was an open PR for it (apparently I only checked whether an issue existed...) |
Author
|
I just saw the comment saying you'd rather not use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arbitrary::genArbitrary::shrinkI tried implementing a non-trivial shrinker, but this ended up requiring
T: Cloneand a lot of lifetime issues, so it seemed better to keep the dummy shrinker.
This PR depends on
constgenerics, so that would bump the MSRV to 1.51 andrequire a minor release. Alternatively, this functionality could be hidden
behind an opt-in feature flag.