Merged
Conversation
…a. This makes it easier to locate the resizing area when using the interface.
…f a block independently. During this process, some duplicated code for setting the size of said panel is removed.
MathisFederico
requested changes
Nov 13, 2021
Member
MathisFederico
left a comment
MathisFederico
left a comment
There was a problem hiding this comment.
You can reduce duplication by using newly defined functions !
Don't worry if there is a lot of comments and change requests, we will learn to work together step by step !
…ssues. Did not run to yet to avoid merge conflicts.
vanyle
force-pushed
the
bug/cursor_and_resize
branch
from
4059048 to
5e5ea8d
Compare
…se moves quickly from the resizing area to outside of it. Also, tied the start of the resizing to the cursor appearance to help with consistency between cursor appearance and if the area is resizable if changes are made.
Refactor execute and update_output using new method get_message
MathisFederico
approved these changes
Nov 14, 2021
Member
MathisFederico
left a comment
MathisFederico
left a comment
There was a problem hiding this comment.
Nice ! I think this can be merged !
It will be re-reviewed when feature/kernel will be merged anyway
message was overriden on last iteration when execution_state is idle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request adds 2 main things:
The pylint score is a bit lower because pylint things that the 2 hover function in
block.pyandcodeblock.pyare too similar but I don't see an easy way to refactor this.