Merged
Conversation
…size code which is now handled by a QSizeGrip and a QSplitter
Fixes issues where a block was shaking when resizing
vanyle
force-pushed
the
feature/size_and_widgets
branch
from
0deb6e8 to
d9b63ff
Compare
Member
|
A few points while testing
|
MathisFederico
requested changes
Nov 18, 2021
Member
MathisFederico
left a comment
MathisFederico
left a comment
There was a problem hiding this comment.
A few things to fix, but a very nice refactor of blocks !
Co-authored-by: Mathïs Fédérico <60117466+MathisFederico@users.noreply.github.com>
…eature/size_and_widgets
MathisFederico
requested changes
Nov 18, 2021
Member
MathisFederico
left a comment
MathisFederico
left a comment
There was a problem hiding this comment.
I don't see buttons when running main ...
Removed a windows specific warning with asyncio.
This was
linked to
issues
Nov 18, 2021
Closed
MathisFederico
requested changes
Nov 18, 2021
Member
There was a problem hiding this comment.
Testing lead to a few things to change:
- Widget states (slider position, output pannel size, ...) are not serialized / deserialized meaning not saved and reloaded, and not kept when copy / pasting.
- Button should be at the left of the title, it takes more space when behind the number line.
- Moves the position of the "Run" button to title bar. - Saves the position of the splitter to a file - Resize events can now be undone - Increases the size of the undo stack to 50 Note that a test is changed because you cannot drag a block from the button.
…people from introducing bugs by blindingly following linter advice;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now use widgets to display elements inside the code blocks.
This fixes multiple resizing bugs, makes the resizable area easier to change and gives better resizing for the python editor.
Moreover, this hugely improves the code quality by removing huge chunks of unused code.