Skip to content

🎉 The title of the blocks is editable by clicking on it.#75

Closed
vanyle wants to merge 21 commits intomasterfrom
feature/editable_title
Closed

🎉 The title of the blocks is editable by clicking on it.#75
vanyle wants to merge 21 commits intomasterfrom
feature/editable_title

Conversation

@vanyle
Copy link
Contributor

@vanyle vanyle commented Nov 28, 2021

This resolves #63

Changed the behavior of the move test so that the mouse clicks further right outside the title area.

Changed the behavior of the move test so that the mouse clicks further right outside the title area.
Reduced the move amount to prevent failure due to moving the block outside the window. The goal of this test is to check that the block moves at the same pace as the mouse
@vanyle
Copy link
Contributor Author

vanyle commented Nov 28, 2021

The move test seems to not be very robust.
A large test refactor with multiple screen configurations (various resolutions) will be required at some point.

In the pull request with "Arrow navigation", a function is available to center the scene on a block. This function should be used instead of the current "hack".

@MathisFederico
Copy link
Member

Some titles are cut now
image

@vanyle
Copy link
Contributor Author

vanyle commented Nov 28, 2021

Because the title is editable, the area where the title is cannot be used to move a block around. A compromise has to be made between the length of the title that is displayed and the ability to easily move a block around.

Currently, the title occupied a third of the header of a block.

I will bump this value to a half but I won't go futher.

The user can still read the full title by clicking on it and moving the cursor around to scroll.

@vanyle
Copy link
Contributor Author

vanyle commented Nov 28, 2021

I will edit this so that the edit occurs on double-click.

@MathisFederico
Copy link
Member

MathisFederico commented Nov 28, 2021

I will edit this so that the edit occurs on double-click.

Then title will be able to be on the full block length

Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use this to make OCBBlock init cleaner.

MathisFederico
MathisFederico previously approved these changes Nov 30, 2021
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good feature !

self.setReadOnly(True)

@property
def metadatas(self) -> dict:
Copy link
Contributor Author

@vanyle vanyle Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "data" uncountable. No "s" is needed.

@vanyle
Copy link
Contributor Author

vanyle commented Nov 30, 2021

The work on this feature was moved to #81

@vanyle vanyle closed this Nov 30, 2021
@vanyle vanyle deleted the feature/editable_title branch November 30, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block renaming

2 participants