This repository was archived by the owner on Dec 20, 2023. It is now read-only.
Monkey patch reconnect due to big in node-amqp #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechnotronicOz
force-pushed
the
monkey_patch_reconnet
branch
from
ad6b0bf to
fc5592d
Compare
doug-martin
approved these changes
Apr 14, 2017
TechnotronicOz
commented
Apr 19, 2017
|
|
||
| return function connect(url, opts) { | ||
| if (!connectionPromise) { | ||
| connectOpts = opts; |
Contributor
Author
There was a problem hiding this comment.
the error handler should be connection.on("close", checkConnected) to handle multiple disconnects from Rabbit, otherwise after your first reconnect, it will not attempt to reconnect.
TechnotronicOz
force-pushed
the
monkey_patch_reconnet
branch
from
fc5592d to
3fee0a8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node-amqp has an open issue with heartbeats not reconnecting if they don't come back. When node-amqp loses connection, it emits an
endwhich is then picked up in the end event listener. From there, it looks to see if thereadyevent was already fired, if it was not, the library then assumes you have an authentication issue and emits an error. The issue lies within here, it never looks to see if the socket was destroyed and then attempts to reconnect.I have created a "fix" version that does not use the
options.reconnectto verify you want to it to reconnect but its more a proof of concept at e30ac3fabdd6379ff2d8e12c489d90371417e364