US354240: Provide CAF Logging support for Serilog

[xbreizh]

https://internal.almoctane.com/ui/entity-navigation?p=131002/6001&entityType=work_item&id=354240

[buildmachine-sou-jenkins2]

CI Build Link:
http://sou-jenkins2.swinfra.net:8080/job/CAFapi/job/CAFapi~caf-logging~US354240~CI

[xbreizh]

@frankmccarry I added the file configuration and it performs as expected. The only downside is that we have to pass the filepath to the configuration as it's a requirement from WriteTo.File . I tested with a default name, but then the template doesn't get applied onto the file mentioned in .ReadFrom.Configuration(configuration).

Here is a sample of call:

var config_path = "C:\\Users\\XLamourec\\IdeaProjects\\caf-logging\\ConsoleApp1\\appsettings.json";
var configuration = new ConfigurationBuilder()
           .AddJsonFile(config_path)
           .Build();

 var levelSwitch = new LoggingLevelSwitch();
 levelSwitch.MinimumLevel = LogEventLevel.Verbose;
 Log.Logger = CafLoggingLoggerConfiguration
     .GetLoggerConfig(levelSwitch, "testlog.txt")
     .ReadFrom.Configuration(configuration)
     .CreateLogger();

[frankmccarry]

I think the changes meet the remit for the ticket.

[dermot-hardy]

So we're saying that if the message being logged contains a control character that it is safe to log!!

[xbreizh]

Reversed the logic

[dermot-hardy]

This check doesn't relate to the comment above. Are we checking if the characters are ASCII, or are we checking if they are control characters?

[xbreizh]

I updated to match what we do here Note that we consider non-latin characters as unsafe.

[dermot-hardy]

Why does the strings being logged have quotes around them? And also why are there extra quotes in the strings in the message field?

I.e. I tried this: Log.Error(ex, "Caught an exception");

I expected: {"message":"Caught an exception","exception":"..."}
But I got: {"message":"\"Caught an exception\"","exception":"..."}

[xbreizh]

Fixed

[dermot-hardy]

• When I tested this I did not see the time coming out in UTC.
• Tenant Id and Correlation Id are not defaulting to a dash if they are not present

[xbreizh]

Both should be fixed now. I am getting: [2022-05-13 15:10:53.160Z #272.001 ERROR - -] c.m.d.f.f.f.FieldFullTextFixer: {"message":"{FirstName"}

[dermot-hardy]

Can't we control the log level by setting the CAF_LOG_LEVEL environment variable the same way we do with the Logback and the Log4j 2 versions?

[xbreizh]

Done