Conversation
Owner
|
I think, you could also remove "odname" and get it from filepath inside exporter. |
Collaborator
Author
agree, but it messed up the tests so i had to do that part later. |
Path.GetFileNameWithoutExtension([FileName] is used internally instead (this is done externally before)
Just basic tests to make sure i did not mess up the directory or filenames
trojanobelix
approved these changes
Jul 23, 2024
Collaborator
trojanobelix
left a comment
trojanobelix
left a comment
There was a problem hiding this comment.
Very nice! Thanks!
CANopenNode
approved these changes
Jul 23, 2024
nimrof
deleted the
124-remove-folderpath-parameter-in-canopennode-exporters
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #124