Skip to content

126 move gitversion from gui to libeds#127

Merged
nimrof merged 5 commits intomainfrom
126-move-gitversion-from-gui-to-libeds
Jul 23, 2024
Merged

126 move gitversion from gui to libeds#127
nimrof merged 5 commits intomainfrom
126-move-gitversion-from-gui-to-libeds

Conversation

@nimrof
Copy link
Copy Markdown
Collaborator

@nimrof nimrof commented Jul 23, 2024 •
edited
Loading

  • resolves move gitversion from gui to libEDS #126
  • moved the assembly info from assemblyinfo.cs into the project for the library to have one place for it.
  • changed workflows to fetch all tags as it is needed to get the git command to work

I will make a getGitVersion function in a exporter baseclass in the near future to minimize code duplication

@nimrof nimrof self-assigned this Jul 23, 2024
@nimrof nimrof linked an issue Jul 23, 2024 that may be closed by this pull request
move gitversion from gui to libEDS #126
Closed
@nimrof nimrof marked this pull request as draft July 23, 2024 08:35
@nimrof nimrof marked this pull request as ready for review July 23, 2024 08:46
trojanobelix
trojanobelix approved these changes Jul 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@trojanobelix trojanobelix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice simplification

@nimrof nimrof merged commit 40c02b3 into main Jul 23, 2024
@nimrof nimrof deleted the 126-move-gitversion-from-gui-to-libeds branch July 23, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trojanobelix trojanobelix trojanobelix approved these changes

@CANopenNode CANopenNode Awaiting requested review from CANopenNode

Assignees

@nimrof nimrof

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

move gitversion from gui to libEDS

2 participants

@nimrof @trojanobelix