Conversation
aryarm
approved these changes
Jul 1, 2022
Member
There was a problem hiding this comment.
nice! thanks for trying it out and double checking that it works!
I think this would be a great addition to the examples section in the docs for the transform subcommand:
Examples
~~~~~~~~
.. code-block:: bash
haptools transform -o output.vcf.gz -s NA12878 tests/data/apoe.vcf.gz tests/data/apoe4.hap
and then you could probably even retitle this PR as a documentation-based PR, for example:
docs: add apoe haplotype example
Collaborator
Author
|
Thanks for these suggestions! I implemented these and am merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding test VCF and haplotypes for apoe4
Example command: