Skip to content

add some broken soil definitions#7

Open
mmaelicke wants to merge 1 commit intomainfrom
broken-soils
Open

add some broken soil definitions#7
mmaelicke wants to merge 1 commit intomainfrom
broken-soils

Conversation

@mmaelicke
Copy link
Contributor

Please do not merge this PR, the soil definitions are broken on purpose, to check that the validator is working

@github-actions
Copy link

CATFLOW input file validation report

Catlidate version: 0.7.0

Object checked errors warnings
Landuse classes valid 0 0
Beets valid 0 0
Coniferous Forest valid 0 0
Corn valid 0 0
Crops & Vegetable valid 0 0
Deciduous forest valid 0 0
Indian Mustard valid 0 0
Grassland valid 0 0
Rapeseed & Field Mus... valid 0 0
Sunflowers valid 0 0
SOIL classes invalid 6 2

Landuse-class definitions

PATH: /home/runner/work/example-parameters/example-parameters/in/landuse
NAME: landuseclass.def
Total classes: 9
Invalid classes: 0

SOIL class definitions

PATH: /home/runner/work/example-parameters/example-parameters/in/Weiherbach_soils.def
NAME: Weiherbach_soils.def
Total soils: 12
Invalid soils: 2

Soil Error Details

  • SOIL: 15-35cm
    • [L. 19] line 19 of SOIL 'IUP: Loess Pflughorizont 15-35cm' has 4 values, but 3 were expected.
    • [L. 19] line 19 of SOIL 'IUP: Loess Pflughorizont 15-35cm' is not correctly indended and might cause problems.
  • SOIL: Loesslehm
    • [L. 20] line 20 of SOIL 'IUP: 1. Loesslehm' has 15 values, but 14 were expected.
    • [L. 21] line 21 of SOIL 'IUP: 1. Loesslehm' has 10 values, but 9 were expected.
    • [L. 22] line 22 of SOIL 'IUP: 1. Loesslehm' has 4 values, but 3 were expected.
    • [L. 23] line 23 of SOIL 'IUP: 1. Loesslehm' has 4 values, but 3 were expected.
    • [L. 23] line 23 of SOIL 'IUP: 1. Loesslehm' is not correctly indended and might cause problems.
    • [L. 24] line 24 of SOIL 'IUP: 1. Loesslehm' has 4 values, but 3 were expected.

@mmaelicke
Copy link
Contributor Author

@JanWien the catflow_validate package is now running some basic checks on the SOIL definitions. This pull request contains some soils, which are broken on purpose. If you can make any sense from the provided error messages, you can go ahead and push the real soil file into the repository.

Copy link
Contributor

@JanWien JanWien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check line numbers:

Error report says L 19 has 4 values instead of 3, but this is the descriptive text line
Not sure where this error is, actually.

Other errors (L. 20 to 24) are reported correctly

@mmaelicke
Copy link
Contributor Author

Check line numbers:

Error report says L 19 has 4 values instead of 3, but this is the descriptive text line Not sure where this error is, actually.

Other errors (L. 20 to 24) are reported correctly

You are right, this does not make much sense. But I get what is going on there: The Soil nr 3 from line 14 onward is missing a line. This is expected to be in line 19. The error messages need to make this clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants