Skip to content

Common - Add option to use vanilla game time (mission config) #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PabstMirror wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Common - Add option to use vanilla game time (mission config) #1323

PabstMirror wants to merge 1 commit into from

Conversation

@PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Apr 5, 2020

ref #1320
simpler fix
just add option to use vanilla time
might not be perfectly synced, but should handle extended plays much better

@PabstMirror PabstMirror mentioned this pull request Apr 5, 2020
Closed
@Vdauphin
Copy link
Contributor

Vdauphin commented Apr 5, 2020

Way better!
Why not make it the default behavior?

@PabstMirror
Copy link
Contributor Author

PabstMirror commented Apr 5, 2020

ref
acemod/ACE3#1092
#273

time may not be synced perfectly between clients/jips
ignores accTime
so there is a reason it exists, but these might be less important than extended play missions

@commy2
Copy link
Contributor

commy2 commented Apr 5, 2020

No.

@commy2 commy2 added this to the 3.15.2 milestone May 30, 2020
@PabstMirror PabstMirror modified the milestones: 3.15.2, 3.16 Sep 16, 2020
@PabstMirror PabstMirror modified the milestones: 3.16, Ongoing Feb 19, 2021
@jonpas
Copy link
Member

jonpas commented Jul 23, 2021

Status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Vdauphin Vdauphin Vdauphin approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Ongoing

Development

Successfully merging this pull request may close these issues.

5 participants

@PabstMirror @Vdauphin @commy2 @jonpas