Tests for contacts & contact lists, added some methods to the API tha… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hapi/contact_lists.py
Outdated
There was a problem hiding this comment.
The word "method" in a restful API may refer to "GET", "POST", "PUT", "DELETE" specifically. Since "subpath" is used everywhere else, and it's also making sense, I'd suggest not changing it.
Author
There was a problem hiding this comment.
Hmm I saw in broadcast.py that they used method as this name, but I only looked there. I'll change back to subpath.
zdelagrange
force-pushed
the
tests_contacts_contact_lists
branch
from
b7f3eb2 to
a6cd5e3
Compare
…t helped me clean up after the testing on the public api
zdelagrange
force-pushed
the
tests_contacts_contact_lists
branch
from
a6cd5e3 to
40bcac6
Compare
tinyx
added a commit
that referenced
this pull request
Sep 10, 2015
Tests for contacts & contact lists, added some methods to the API tha…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t helped me clean up after the testing on the public api