Skip to content

Implement customized reset functionality #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2767mr merged 2 commits into from
Jan 29, 2023
Merged

Implement customized reset functionality #3

2767mr merged 2 commits into from
Jan 29, 2023

Conversation

@EpicYoshiMaster
Copy link
Member

@EpicYoshiMaster EpicYoshiMaster commented Jan 21, 2023

Changes

  • Uses patch file for localized text
  • Fixes an issue where combined events did not pass the action through for recursive checks
  • Implements two new options for whether pressing New Game or starting a Preset will reset splits
  • Adds a hotkey which can do this manually at any time for runs that use several files / want to start from a non-preset location.

2767mr
2767mr approved these changes Jan 28, 2023
View reviewed changes
2767mr
2767mr requested changes Jan 28, 2023
View reviewed changes
Copy link
Member

@2767mr 2767mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved it by mistake. Please resolve the issues above first.

@EpicYoshiMaster
Address requested changes
299a57c 
- labels moved back into utils
- removed injection into sc.Control
- input-api is now an optional dependency

(also fixed a visual timer bug that I forgot to address a while back)
@2767mr 2767mr merged commit 64cee91 into CCDirectLink:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2767mr 2767mr 2767mr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EpicYoshiMaster @2767mr