Skip to content

Changed default vector values to 0 #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2767mr wants to merge 3 commits into from
Closed

Changed default vector values to 0 #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
496da41
Changed default vector values to 0
2767mr Mar 12, 2023
5af4d57
Added changelog
2767mr Mar 12, 2023
c3272f2
Added changelog
2767mr Mar 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [Unreleased]

### Changed
- Default values for Vec2 are now 0,0 instead of 1,1.


## [0.17.1] 2022-11-13
- Fixed a bug where pasting an entity would insert those entities twice.

Expand Down
4 changes: 2 additions & 2 deletions webapp/src/app/components/widgets/vec2-widget/vec2-widget.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ export class Vec2WidgetComponent extends AbstractWidget implements OnChanges {
if (!this.settings[this.key]) {
const minSize = this.scaleSettings.baseSize;
const value = {
x: minSize.x > 0 ? minSize.x : 1,
y: minSize.y > 0 ? minSize.y : 1
x: minSize.x > 0 ? minSize.x : 0,
y: minSize.y > 0 ? minSize.y : 0
};
this.settings[this.key] = value;
this.updateType(value);
Expand Down