-
Notifications
You must be signed in to change notification settings - Fork 18
added graphical selector for some entities and fixed some issues #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… having issues like continue dragging entities even if the mouse button was released
# Conflicts: # CHANGELOG.md # webapp/src/app/services/phaser/entities/entity-manager.ts
2767mr
requested changes
Jul 24, 2023
Member
2767mr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things I noticed:
- A loading indicator would be nice
- Search should include sub types (with toggle?)
- Perhaps it would look better if this is centered?

- I think this could use some extra margin-right

- There is no good way to see the full name of the character now. In my other projects I usually do
text-overflow: ellipsiswith a tooltip containing the full text. This would clash with the existing tooltips here but maybe we can figure something out.

- Creating a new ScalableProp creates a 1x1 px entity (was already the case before this PR)
- I thought about opening the prop picker after double clicking props but that would probably be a bit much. Maybe opening it after creating a new prop would be nice?
Things I really liked:
- The "transparent texture"
- The size change on hover
- The red outline
- The counter in the top right of the props
- The prop rendering. That one has bothered me for a long time.
...nents/widgets/shared/image-select-overlay/image-select-card/image-select-card.component.scss
Outdated
Show resolved
Hide resolved
Member
Author
This was
linked to
issues
Aug 1, 2023
Member
|
Can this be made to scroll down to the selected prop/enemy/destructible when you open the modal again? |
2767mr
approved these changes
Aug 3, 2023
Member
Author
|
@lexisother made a new issue for it #277 |
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Added New graphical selection widget for some entities:
Prop
ScalableProp
Enemy
ItemDestruct
other changes
PropEntities should now be rendered correctlyScalableProprendering.endsare now rendered correctly.