Skip to content

Conversation

@Vegita2
Copy link
Member

@Vegita2 Vegita2 commented Jul 21, 2023

Added New graphical selection widget for some entities:

Prop

image

ScalableProp

image

Enemy

image

ItemDestruct

image

other changes

  • Updated Phaser to 3.60.0
  • Entity copy/paste now uses the clipboard to make it easier working with multiple editor instances use clipboard for entity copy #267
  • All Prop Entities should now be rendered correctly
  • Improved ScalableProp rendering. ends are now rendered correctly.
  • Releasing mouse button outside the canvas now properly triggers. Avoids having issues like continue dragging entities even if the mouse button was released

@Vegita2 Vegita2 requested a review from 2767mr July 21, 2023 22:09
@Vegita2 Vegita2 linked an issue Jul 22, 2023 that may be closed by this pull request
@Vegita2 Vegita2 marked this pull request as draft July 22, 2023 23:52
@Vegita2 Vegita2 marked this pull request as ready for review July 23, 2023 22:51
Copy link
Member

@2767mr 2767mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things I noticed:

  • A loading indicator would be nice
  • Search should include sub types (with toggle?)
  • Perhaps it would look better if this is centered?
    image
  • I think this could use some extra margin-right
    image
  • There is no good way to see the full name of the character now. In my other projects I usually do text-overflow: ellipsis with a tooltip containing the full text. This would clash with the existing tooltips here but maybe we can figure something out.
    image
  • Creating a new ScalableProp creates a 1x1 px entity (was already the case before this PR)
  • I thought about opening the prop picker after double clicking props but that would probably be a bit much. Maybe opening it after creating a new prop would be nice?

Things I really liked:

  • The "transparent texture"
  • The size change on hover
  • The red outline
  • The counter in the top right of the props
  • The prop rendering. That one has bothered me for a long time.

@Vegita2
Copy link
Member Author

Vegita2 commented Jul 24, 2023

I thought about opening the prop picker after double clicking props but that would probably be a bit much. Maybe opening it after creating a new prop would be nice?

We could always trigger the double click when adding a new entity, but not sure if it's always the first thing you want to do. I would keep it like it currently is for now and decide later with some user feedback. It could also be toggleable in the settings menu

  • Perhaps it would look better if this is centered?
    image
  • A loading indicator would be nice
  • Search should include sub types (with toggle?)
  • I think this could use some extra margin-right
    image
  • There is no good way to see the full name of the character now. In my other projects I usually do text-overflow: ellipsis with a tooltip containing the full text. This would clash with the existing tooltips here but maybe we can figure something out.
    image
  • Creating a new ScalableProp creates a 1x1 px entity (was already the case before this PR)

@lexisother
Copy link
Member

Can this be made to scroll down to the selected prop/enemy/destructible when you open the modal again?

@Vegita2
Copy link
Member Author

Vegita2 commented Aug 4, 2023

@lexisother made a new issue for it #277

@Vegita2 Vegita2 enabled auto-merge August 4, 2023 13:10
@Vegita2 Vegita2 merged commit bf2b3c9 into master Aug 4, 2023
@Vegita2 Vegita2 deleted the 228-prop-selector branch August 4, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use clipboard for entity copy Change ScalableProp default patternOffset to 0,0 Implement a prop selector

4 participants