Skip to content

Conversation

@Aadeesh11
Copy link
Contributor

@Aadeesh11 Aadeesh11 commented Feb 4, 2022

#46

Describe the changes you have made in this PR - Tested beacon and user model's methods.

@Aadeesh11 Aadeesh11 force-pushed the tests branch 2 times, most recently from b9e3a35 to fe336f1 Compare February 4, 2022 17:18
@Aadeesh11 Aadeesh11 changed the title Test: Beacon Model test. Test: Model test (Beacon and User model). Feb 4, 2022
Diff Lat/Lon values.

User model test added.

Added update method test.
nb9960
nb9960 previously approved these changes Feb 12, 2022
Comment on lines 9 to 10
"name": "asdasd",
"email": "asdf@g.com",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding random alphabets, I think it would be better to be more generic, like change it to "test_name"
And also since you've written the model tests it would be better to add validation check too. For ex: _id can't be null (similarly for other fields in user and beacon model)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do the needful!

@nb9960 nb9960 dismissed their stale review February 12, 2022 14:09

Changes requested

This was referenced Feb 12, 2022
@nb9960 nb9960 linked an issue Feb 12, 2022 that may be closed by this pull request
8 tasks
@nb9960 nb9960 merged commit 7985f5a into CCExtractor:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tests]: Write Test for beacon project.

2 participants