fixed sorting-function error#199
Merged
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom Nov 17, 2025
Merged
Conversation
ShivaGupta-14
pushed a commit
to ShivaGupta-14/ccsync
that referenced
this pull request
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where sorting by status or ID stopped working whenever any filters (tags, projects, or status) were applied.
The filtering useEffect was always overwriting tempTasks with a fixed ID-sorted list, causing the user’s selected sort order to be lost.
What Was Happening
-Sorting worked correctly at first.
-After applying any filter, the filter useEffect would run.
-This effect reset tempTasks using sortTasksById(filteredTasks, 'desc'), ignoring the selected sort order.
-As a result, sorting became unresponsive when filters were active.
What This PR Changes
-Removed the forced sorting inside the filtering useEffect.
-Filtering now only filters the tasks and does not override the user’s sort order.
Sorting by ID and Status now works correctly even after applying:
-Tag filters
-Project filters
-Status filters
- Fixes: #185
After fix
Screencast from 17-11-25 08:28:44 PM IST.webm