Skip to content

fix: include EncryptionSecret in downloaded configuration file#239

Merged
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
Eshaan-byte:fix/add-encryption-secret-to-download-238
Dec 3, 2025
Merged

fix: include EncryptionSecret in downloaded configuration file#239
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
Eshaan-byte:fix/add-encryption-secret-to-download-238

Conversation

@Eshaan-byte
Copy link
Copy Markdown
Contributor

Fixes #238

The Download Configuration button was generating a text file that was missing the EncryptionSecret command. This PR adds the missing encryption_secret configuration line to the exportConfigSetup function.

Changes

  • Added task config sync.encryption_secret ${props.encryption_secret} to the exported configuration in frontend/src/components/HomeComponents/SetupGuide/utils.ts

Before

The downloaded configuration file only contained:

  • ✅ Sync Server Origin
  • ✅ Client ID
  • ❌ Encryption Secret (missing)

After

The downloaded configuration file now contains all three required values:

  • ✅ Encryption Secret
  • ✅ Sync Server Origin
  • ✅ Client ID

Test plan

  • Identified the bug in the exportConfigSetup function
  • Added the missing encryption secret line
  • Verified the fix matches the UI display order

Fixes CCExtractor#238

The Download Configuration button was generating a text file that was missing the EncryptionSecret command. This commit adds the missing encryption_secret configuration line to the exportConfigSetup function, ensuring the downloaded file contains all three required values:
- Encryption Secret
- Sync Server Origin
- Client ID
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2025

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

Copy link
Copy Markdown
Contributor Author

@Eshaan-byte Eshaan-byte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Self-review completed. Added the missing encryption secret to the download configuration."

@@ -4,6 +4,7 @@ import { url } from '@/components/utils/URLs';
export function exportConfigSetup(props: Props): string {
return [
'Configure Taskwarrior with these commands, run these commands one block at a time',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the missing encryption_secret configuration command to ensure
the downloaded file includes all required setup values.

@its-me-abhishek its-me-abhishek merged commit 22e8b11 into CCExtractor:main Dec 3, 2025
5 checks passed
ShivaGupta-14 pushed a commit to ShivaGupta-14/ccsync that referenced this pull request Dec 25, 2025
…ractor#239)

Fixes CCExtractor#238

The Download Configuration button was generating a text file that was missing the EncryptionSecret command. This commit adds the missing encryption_secret configuration line to the exportConfigSetup function, ensuring the downloaded file contains all three required values:
- Encryption Secret
- Sync Server Origin
- Client ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Missing value upon Downloading Configuration

2 participants