Skip to content

Fix hero cards layout #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
its-me-abhishek merged 2 commits into from
Dec 9, 2025
Merged

Fix hero cards layout #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bff032
Fix hero cards overlapping on medium screen sizes
LipikaAggarwal Dec 8, 2025
b23fc71
Fix hero cards overlapping on medium screen sizes
LipikaAggarwal Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions frontend/src/components/LandingComponents/Hero/HeroCards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,14 @@ const popIn = {

export const HeroCards = () => {
return (
<div className="hidden lg:flex flex-row flex-wrap gap-8 relative w-[700px] h-[500px]">
// Prevent overflow at lg breakpoint
<div className="hidden lg:flex flex-row flex-wrap gap-8 relative lg:w-[560px] lg:h-[480px] xl:w-[700px] xl:h-[500px]">
<motion.div
whileHover={'hover'}
initial="hidden"
animate="visible"
variants={popIn}
className="mt-4 absolute w-[340px] -top-[15px] drop-shadow-xl shadow-black/10 dark:shadow-white/10"
className="mt-4 absolute lg:w-[300px] xl:w-[340px] -top-[30px] drop-shadow-xl shadow-black/10 dark:shadow-white/10"
>
<Card>
<CardContent className="text-center pb-2 mt-5 mb-5">
Expand All @@ -29,7 +30,7 @@ export const HeroCards = () => {
initial="hidden"
animate="visible"
variants={popIn}
className="absolute right-[20px] mt-5 top-4 w-80 flex flex-col justify-center items-center drop-shadow-xl shadow-black/10 dark:shadow-white/10"
className="absolute lg:right-[30px] xl:right-[8px] mt-5 top-20 lg:w-[260px] xl:w-80 flex flex-col justify-center items-center drop-shadow-xl shadow-black/10 dark:shadow-white/10"
Copy link
Copy Markdown
Contributor Author

@LipikaAggarwal LipikaAggarwal Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted the card width and right offset on the lg breakpoint to prevent horizontal clipping at 1024px.

>
<Card>
<CardContent className="text-center pb-2 mt-5 mb-5">
Expand All @@ -45,7 +46,7 @@ export const HeroCards = () => {
initial="hidden"
animate="visible"
variants={popIn}
className="absolute top-[150px] left-[50px] w-72 drop-shadow-xl shadow-black/10 dark:shadow-white/10"
className="absolute lg:top-[240px] lg:left-[24px] xl:top-[170px] xl:left-[40px] w-72 drop-shadow-xl shadow-black/10 dark:shadow-white/10"
>
<Card>
<CardContent className="text-center pb-2 mt-5 mb-5">
Expand All @@ -58,7 +59,7 @@ export const HeroCards = () => {
initial="hidden"
animate="visible"
variants={popIn}
className="absolute w-[350px] -right-[10px] bottom-[135px] drop-shadow-xl shadow-black/10 dark:shadow-white/10"
className="absolute lg:w-[290px] xl:w-[350px] lg:right-[30px] xl:-right-[6px] lg:bottom-[20px] xl:bottom-[90px] drop-shadow-xl shadow-black/10 dark:shadow-white/10"
>
<Card>
<CardContent className="text-center pb-5 mt-5 mb-5">
Expand Down
10 changes: 5 additions & 5 deletions ...end/src/components/LandingComponents/Hero/__tests__/__snapshots__/HeroCards.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
exports[`HeroCard component using snapshot renders correctly 1`] = `
<DocumentFragment>
<div
class="hidden lg:flex flex-row flex-wrap gap-8 relative w-[700px] h-[500px]"
class="hidden lg:flex flex-row flex-wrap gap-8 relative lg:w-[560px] lg:h-[480px] xl:w-[700px] xl:h-[500px]"
>
<div
class="mt-4 absolute w-[340px] -top-[15px] drop-shadow-xl shadow-black/10 dark:shadow-white/10"
class="mt-4 absolute lg:w-[300px] xl:w-[340px] -top-[30px] drop-shadow-xl shadow-black/10 dark:shadow-white/10"
style="opacity: 0; will-change: transform,opacity; transform: scale(0.9);"
>
<div
Expand All @@ -20,7 +20,7 @@ exports[`HeroCard component using snapshot renders correctly 1`] = `
</div>
</div>
<div
class="absolute right-[20px] mt-5 top-4 w-80 flex flex-col justify-center items-center drop-shadow-xl shadow-black/10 dark:shadow-white/10"
class="absolute lg:right-[30px] xl:right-[8px] mt-5 top-20 lg:w-[260px] xl:w-80 flex flex-col justify-center items-center drop-shadow-xl shadow-black/10 dark:shadow-white/10"
style="opacity: 0; will-change: transform,opacity; transform: scale(0.9);"
>
<div
Expand All @@ -36,7 +36,7 @@ exports[`HeroCard component using snapshot renders correctly 1`] = `
</div>
</div>
<div
class="absolute top-[150px] left-[50px] w-72 drop-shadow-xl shadow-black/10 dark:shadow-white/10"
class="absolute lg:top-[240px] lg:left-[24px] xl:top-[170px] xl:left-[40px] w-72 drop-shadow-xl shadow-black/10 dark:shadow-white/10"
style="opacity: 0; will-change: transform,opacity; transform: scale(0.9);"
>
<div
Expand All @@ -52,7 +52,7 @@ exports[`HeroCard component using snapshot renders correctly 1`] = `
</div>
</div>
<div
class="absolute w-[350px] -right-[10px] bottom-[135px] drop-shadow-xl shadow-black/10 dark:shadow-white/10"
class="absolute lg:w-[290px] xl:w-[350px] lg:right-[30px] xl:-right-[6px] lg:bottom-[20px] xl:bottom-[90px] drop-shadow-xl shadow-black/10 dark:shadow-white/10"
style="opacity: 0; will-change: transform,opacity; transform: scale(0.9);"
>
<div
Expand Down
Loading