Skip to content

fix: navbar delete logic to prevent empty deletes#261

Merged
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
LipikaAggarwal:fix/navbar-delete-logic
Dec 9, 2025
Merged

fix: navbar delete logic to prevent empty deletes#261
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
LipikaAggarwal:fix/navbar-delete-logic

Conversation

@LipikaAggarwal
Copy link
Copy Markdown
Contributor

@LipikaAggarwal LipikaAggarwal commented Dec 9, 2025

Description

This PR fixes the navbar "Delete all tasks" behavior by preventing the delete action when there are no tasks available for the selected user. A user-facing toast message is shown instead to clearly indicate that there are no tasks to delete.

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

  • Manual testing was performed to verify:
    • Delete works correctly when tasks exist
    • Delete is blocked and a toast is shown when no tasks exist

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

@its-me-abhishek
Copy link
Copy Markdown
Collaborator

@LipikaAggarwal please create an issue for this PR first, so as to provide more context

@its-me-abhishek its-me-abhishek changed the title Fix navbar delete logic to prevent empty deletes fix: navbar delete logic to prevent empty deletes Dec 9, 2025
@its-me-abhishek its-me-abhishek merged commit a42f0e8 into CCExtractor:main Dec 9, 2025
5 checks passed
ShivaGupta-14 pushed a commit to ShivaGupta-14/ccsync that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navbar "Delete All Tasks" triggers even when no tasks exist

2 participants