fix(tasks): use uuid instead of id for dialog open condition#272
Merged
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom Dec 12, 2025
Merged
Conversation
Taskwarrior assigns id=0 to all completed and deleted tasks since they are removed from the active task list. Using task.id for the dialog's open condition caused multiple dialogs to open simultaneously when clicking on any non-pending task, resulting in flickering and blackout. Replaced _selectedTask?.id === task.id with _selectedTask?.uuid === task.uuid since uuid is unique for every task regardless of status. Fixes: CCExtractor#271
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
ShivaGupta-14
added a commit
to ShivaGupta-14/ccsync
that referenced
this pull request
Dec 25, 2025
…ctor#272) Taskwarrior assigns id=0 to all completed and deleted tasks since they are removed from the active task list. Using task.id for the dialog's open condition caused multiple dialogs to open simultaneously when clicking on any non-pending task, resulting in flickering and blackout. Replaced _selectedTask?.id === task.id with _selectedTask?.uuid === task.uuid since uuid is unique for every task regardless of status. Fixes: CCExtractor#271
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Taskwarrior assigns id=0 to all completed and deleted tasks since they are removed from the active task list. Using task.id for the dialog's open condition caused multiple dialogs to open simultaneously when clicking on any non-pending task, resulting in flickering and blackout.
Replaced _selectedTask?.id === task.id with
_selectedTask?.uuid === task.uuid since uuid is unique for every task regardless of status.
Fixes: #271
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Video:
Screen.Recording.2025-12-12.at.2.41.55.AM.mov