fix(date-picker): remove modal prop to prevent focus trap conflict#280
Merged
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom Dec 19, 2025
Merged
Conversation
- Removed modal={true} from Popover component in date-picker.tsx.
- Prevents nested focus trap conflict.
- Fixes page becoming unresponsive after clicking outside date picker.
Fixes: CCExtractor#279
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
1 task
6 tasks
ShivaGupta-14
added a commit
to ShivaGupta-14/ccsync
that referenced
this pull request
Dec 25, 2025
…CExtractor#280) - Removed modal={true} from Popover component in date-picker.tsx. - Prevents nested focus trap conflict. - Fixes page becoming unresponsive after clicking outside date picker. Fixes: CCExtractor#279
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Root Cause: The
modal={true}prop on the Popover created a nested focus trap inside the Dialog's existing focus trap. When the calendar closed, both focus traps competed for control, leaving the page in an unresponsive state.Solution: Removing
modal={true}allows the Popover to work within the parent Dialog's focus trap instead of creating its own, eliminating the conflict.Fixes: #279
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Self-Review
I've reviewed my changes and confirm:
Video:
Screen.Recording.2025-12-15.at.12.57.26.AM.mov