Skip to content

Bug/bugs in dialog #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
its-me-abhishek merged 2 commits into from
Dec 17, 2025
+8 −9
Merged

Bug/bugs in dialog #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeeaea0
fixed bugs in dialog
Neeraj-gagat Dec 15, 2025
69a03c8
fixed #281
Neeraj-gagat Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,10 @@ export const TaskDialog = ({
data-testid={`task-row-${task.id}`}
id={`task-row-${task.id}`}
key={index}
className={`border-b cursor-pointer ${
selectedIndex === index ? 'bg-muted/50' : ''
className={`border-b cursor-pointer hover:dark:bg-muted/50 hover:bg-black/15 ${
selectedIndex === index ? 'dark:bg-muted/50 bg-black/15' : ''
}`}
data-selected={selectedIndex === index}
onClick={() => {
onSelectTask(task, index);
}}
Expand Down
1 change: 1 addition & 0 deletions frontend/src/components/HomeComponents/Tasks/Tasks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ export const Tasks = (
target instanceof HTMLTextAreaElement ||
target instanceof HTMLSelectElement ||
_isDialogOpen ||
isAddTaskOpen ||
target.isContentEditable
) {
return;
Expand Down
11 changes: 4 additions & 7 deletions frontend/src/components/HomeComponents/Tasks/__tests__/TaskDialog.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,19 +609,16 @@ describe('TaskDialog Component', () => {

describe('Selected State', () => {
test('should highlight selected task row', () => {
const { container } = render(
<TaskDialog {...defaultProps} selectedIndex={0} />
);
render(<TaskDialog {...defaultProps} selectedIndex={0} />);

const taskRow = container.querySelector('.bg-muted\\/50');
expect(taskRow).toBeInTheDocument();
const taskRow = screen.getByText(mockTask.description).closest('tr');
expect(taskRow).toHaveAttribute('data-selected', 'true');
});

test('should not highlight non-selected task row', () => {
render(<TaskDialog {...defaultProps} selectedIndex={1} />);

const taskRow = screen.getByText(mockTask.description).closest('tr');
expect(taskRow).not.toHaveClass('bg-muted/50');
expect(taskRow).toHaveAttribute('data-selected', 'false');
});
});

Expand Down
Loading