feat(AddTask): Add wait date field to Add Task dialog#292
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
ShivaGupta-14
changed the title
ShivaGupta-14
left a comment
ShivaGupta-14
left a comment
There was a problem hiding this comment.
self review complete! Please take a look when you get a chance. Happy to address any feedback or suggestions
There was a problem hiding this comment.
added wait field to this struct to accept it from frontend
There was a problem hiding this comment.
update the function call to accept this new parameter.
There was a problem hiding this comment.
update the function to accept new parameter and only append the wait field is non-empty which ensures it remains optional.
There was a problem hiding this comment.
updated existing tests to include new waitDate parameter and added two new tests to check that it works correctly.
There was a problem hiding this comment.
added new wait field to newTask state intialization and passed it to addTaskToBackend when submitting, and after submission, reset it.
There was a problem hiding this comment.
added wait field to the addTaskToBackend function that will be sent to the backend's /add-task endpoint.
There was a problem hiding this comment.
added wait-date picker ui
There was a problem hiding this comment.
added new test cases for new wait field
ShivaGupta-14
left a comment
ShivaGupta-14
left a comment
There was a problem hiding this comment.
self review complete! Please take a look when you get a chance. Happy to address any feedback or suggestions
ShivaGupta-14
force-pushed
the
feat/188-add-wait-to-addTask
branch
from
e278983 to
14080a1
Compare
- Add wait date field to backend request body and Taskwarrior CLI - Implement wait date picker in AddTaskDialog frontend component - Update type definitions and hooks to support wait field - Add comprehensive frontend and backend tests for the new field Issue: CCExtractor#188
ShivaGupta-14
force-pushed
the
feat/188-add-wait-to-addTask
branch
from
14080a1 to
b082671
Compare
|
Hi @its-me-abhishek! Whenever you get time, could you please review it? |
- Add wait date field to backend request body and Taskwarrior CLI - Implement wait date picker in AddTaskDialog frontend component - Update type definitions and hooks to support wait field - Add comprehensive frontend and backend tests for the new field Issue: CCExtractor#188
2 participants
Add Wait Date Field to Add Task Dialog
Description
Implemented the
waitdate field in the Add Task dialog, allowing users to specify the wait date when creating a new task.Previously, the
waitfield could only be set via the CLI tool. This change makes it accessible directly from the UI while keeping it completely optional.Updates: #188
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Video:
Screen.Recording.2025-12-22.at.1.23.00.AM.mov