Skip to content

feat: Add end field: backend + frontend; validate end >= start; update swagger#294

Closed
jnakaigen wants to merge 2 commits intoCCExtractor:mainfrom
jnakaigen:add/end-field-backend-frontend
Closed

feat: Add end field: backend + frontend; validate end >= start; update swagger#294
jnakaigen wants to merge 2 commits intoCCExtractor:mainfrom
jnakaigen:add/end-field-backend-frontend

Conversation

@jnakaigen
Copy link
Copy Markdown

@jnakaigen jnakaigen commented Dec 22, 2025

Description

Adds an end field to tasks (backend models, request bodies, Taskwarrior helpers).

Validates on server that end is greater than or equal to start.

Wires end through the frontend Add/Edit task UI and API payloads.

Updates Swagger docs to document the new field.

Fixes: #188

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

Backend tests that invoke external binaries will fail on Windows unless run inside Docker/WSL or the CI environment. I validated end-to-end task add in Docker after updating .env to use the syncserver service name.
image

@github-actions
Copy link
Copy Markdown

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

@jnakaigen jnakaigen changed the title Add end field: backend + frontend; validate end >= start; update swagger feat: Add end field: backend + frontend; validate end >= start; update swagger Dec 22, 2025
@jnakaigen
Copy link
Copy Markdown
Author

Thanks for the guidance!
I’ve gone through the Files changed tab and added comments where I thought clarification was needed (e.g., function naming choices and validation logic).
I also explained why I added the end field and the validation check (end >= start), and noted a couple of areas that might need further discussion in future updates.
Please let me know if there’s anything else I should expand on in my self-review.

@its-me-abhishek
Copy link
Copy Markdown
Collaborator

@jnakaigen this got fixed by #293 apparently, closing for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more Fields to the Add Task Panel

2 participants