Skip to content

feat: make annotations field editable#298

Merged
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
Hell1213:feat/make-annotations-editable
Dec 24, 2025
Merged

feat: make annotations field editable#298
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
Hell1213:feat/make-annotations-editable

Conversation

@Hell1213
Copy link
Copy Markdown
Contributor

Added full annotations editing functionality following the same pattern as tags editing. Users can now add, edit, and remove task annotations through the task details dialog. Backend handles proper annotation replacement using TaskWarrior's denotate/annotate commands.

Changes Made

  • Backend: Added annotations field to request body, implemented TaskWarrior denotate/annotate commands
  • Frontend: Added annotation editing UI with input field and badges, following tags pattern
  • Tests: Updated all test files to cover annotation functionality

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (46 test suites, 345 tests passed)
  • Added unit tests for annotation features
  • Verified all tests pass

Additional Notes

Core Files Modified:

  • backend/models/request_body.go, backend/utils/tw/edit_task.go - Backend annotation handling
  • frontend/src/components/utils/types.ts, TaskDialog.tsx, Tasks.tsx - Frontend annotation UI

Test Files Updated (for annotation coverage):

  • backend/utils/tw/taskwarrior_test.go - Backend annotation tests
  • frontend/src/components/HomeComponents/Tasks/__tests__/TaskDialog.test.tsx - UI component tests
  • frontend/src/components/HomeComponents/Tasks/__tests__/UseEditTask.test.ts - Hook functionality tests

Implementation: Uses TaskWarrior's denotate/annotate commands to handle annotation replacement, following exact same pattern as existing tags functionality.

Demo Video :

Screencast.from.2025-12-24.02-07-45.mp4

@github-actions
Copy link
Copy Markdown

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

Added full annotations editing functionality following the same pattern as tags editing. Users can now add, edit, and remove task annotations through the task details dialog.

Backend handles proper annotation replacement using TaskWarrior's denotate/annotate commands.
@Hell1213 Hell1213 force-pushed the feat/make-annotations-editable branch from 2693432 to f40007e Compare December 23, 2025 22:39
Copy link
Copy Markdown
Contributor Author

@Hell1213 Hell1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

complete the self Review:

  • Backend uses TaskWarrior's denotate + annotate commands to handle annotation replacement (since TaskWarrior only supports append-only annotations)
  • Frontend UI mirrors tags editing with input field, badges, and save/cancel actions

@its-me-abhishek its-me-abhishek merged commit a518d92 into CCExtractor:main Dec 24, 2025
4 checks passed
@its-me-abhishek its-me-abhishek changed the title Make annotations field editable feat: make annotations field editable Dec 24, 2025
ShivaGupta-14 pushed a commit to ShivaGupta-14/ccsync that referenced this pull request Dec 25, 2025
Added full annotations editing functionality following the same pattern as tags editing. Users can now add, edit, and remove task annotations through the task details dialog.

Backend handles proper annotation replacement using TaskWarrior's denotate/annotate commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants