feat: make annotations field editable#298
Merged
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom Dec 24, 2025
Merged
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Added full annotations editing functionality following the same pattern as tags editing. Users can now add, edit, and remove task annotations through the task details dialog. Backend handles proper annotation replacement using TaskWarrior's denotate/annotate commands.
2693432 to
f40007e
Compare
Hell1213
commented
Dec 23, 2025
Contributor
Author
Hell1213
left a comment
There was a problem hiding this comment.
complete the self Review:
- Backend uses TaskWarrior's
denotate+annotatecommands to handle annotation replacement (since TaskWarrior only supports append-only annotations) - Frontend UI mirrors tags editing with input field, badges, and save/cancel actions
its-me-abhishek
approved these changes
Dec 24, 2025
ShivaGupta-14
pushed a commit
to ShivaGupta-14/ccsync
that referenced
this pull request
Dec 25, 2025
Added full annotations editing functionality following the same pattern as tags editing. Users can now add, edit, and remove task annotations through the task details dialog. Backend handles proper annotation replacement using TaskWarrior's denotate/annotate commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added full annotations editing functionality following the same pattern as tags editing. Users can now add, edit, and remove task annotations through the task details dialog. Backend handles proper annotation replacement using TaskWarrior's denotate/annotate commands.
Changes Made
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(46 test suites, 345 tests passed)Additional Notes
Core Files Modified:
backend/models/request_body.go,backend/utils/tw/edit_task.go- Backend annotation handlingfrontend/src/components/utils/types.ts,TaskDialog.tsx,Tasks.tsx- Frontend annotation UITest Files Updated (for annotation coverage):
backend/utils/tw/taskwarrior_test.go- Backend annotation testsfrontend/src/components/HomeComponents/Tasks/__tests__/TaskDialog.test.tsx- UI component testsfrontend/src/components/HomeComponents/Tasks/__tests__/UseEditTask.test.ts- Hook functionality testsImplementation: Uses TaskWarrior's denotate/annotate commands to handle annotation replacement, following exact same pattern as existing tags functionality.
Demo Video :
Screencast.from.2025-12-24.02-07-45.mp4