test(AddTaskDialog): Add test suite for AddTaskDialog component#305
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
08d027e to
0c748cc
Compare
|
Line # 194 is untested as per the console, please fix/provide some context for future |
<SelectContent
onWheel={(e) => e.stopPropagation()} // Line 225
className="max-h-60 overflow-y-auto"
>As line 225 is a UX scroll prevention handler and as per guidelines mentioned in issue: 'focus should be on meaningful tests rather than coverage-only tests', I left this untested as it doesn't affect component behavior or state. Also, Line 51 is a defensive check in Let me know what you prefer! |
0c748cc to
4935448
Compare
- Reorganize tests into logical describe blocks for better readability - Use test.each for Date Fields to eliminate repetitive test code - Add comprehensive tests for Annotations - Add tests for Recur field dropdown selection - Add tests for Project field create new / select existing flow - Cover edge cases: empty inputs, whitespace-only, duplicate prevention Updates: CCExtractor#300
4935448 to
da3d5ec
Compare
Description
Improved test coverage for the AddTaskDialog component. Previously, the component lacked proper test for newer fields like annotations, recurrence, and date pickers.
Changes:
test.eachfor Date Fields to eliminate repetitive test codeUpdates: #300
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Screenshots