fix: accessibility warnings in mobile navbar dialogs#336
Merged
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom Dec 27, 2025
Merged
fix: accessibility warnings in mobile navbar dialogs#336its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Collaborator
|
Thanks for the PR! Do star the project to stay updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Radix UI accessibility warnings in the mobile navbar by adding the required
accessibility metadata to dialog and sheet components.
Adds a
DialogDescriptionto the Auto Sync dialogAdds a
SheetDescriptionto the mobile navigation sheetFixes: Bug: Enable auto sync button on mobile view throws a silent error warning #320
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)