fix: delete all tasks dialog state conflict#337
Merged
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom Dec 27, 2025
Merged
fix: delete all tasks dialog state conflict#337its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Hell1213
commented
Dec 27, 2025
Contributor
Author
Hell1213
left a comment
There was a problem hiding this comment.
Restored proper DialogTrigger pattern with onSelect={(e) => e.preventDefault()}
its-me-abhishek
approved these changes
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed delete all tasks dialog closing immediately and freezing screen by restoring proper DialogTrigger pattern with onSelect={(e) => e.preventDefault()} to match other dialogs in NavbarDesktop component.
Fixes: #321
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Dialog now works correctly without screen freeze. Solution follows existing code patterns used by Export and DevLogs dialogs in the same component.
Demo
Screencast.from.2025-12-27.21-03-44.mp4