Skip to content

fix: convert __NONE__ project placeholder to empty string #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
its-me-abhishek merged 1 commit into from
Jan 7, 2026
Merged

fix: convert __NONE__ project placeholder to empty string #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/src/components/HomeComponents/Tasks/AddTaskDialog.tsx
View file
Open in desktop
Copy link
Copy Markdown
Contributor Author

@ShivaGupta-14 ShivaGupta-14 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converts NONE to empty string when "No project" is selected

Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,9 @@ export const AddTaskdialog = ({
if (value === '__CREATE_NEW__') {
setIsCreatingNewProject(true);
setNewTask({ ...newTask, project: '' });
} else if (value === '__NONE__') {
setIsCreatingNewProject(false);
setNewTask({ ...newTask, project: '' });
} else {
setIsCreatingNewProject(false);
setNewTask({ ...newTask, project: value });
Expand Down
15 changes: 15 additions & 0 deletions frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
View file
Open in desktop
Copy link
Copy Markdown
Contributor Author

@ShivaGupta-14 ShivaGupta-14 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added unit test

Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,21 @@ describe('AddTaskDialog Component', () => {
});

describe('Project Field', () => {
test('sets project to empty string when "No project" is selected', () => {
mockProps.isOpen = true;
mockProps.uniqueProjects = ['Work', 'Personal'];
render(<AddTaskdialog {...mockProps} />);

const projectSelect = screen.getByTestId('project-select');
fireEvent.change(projectSelect, { target: { value: '__NONE__' } });

expect(mockProps.setIsCreatingNewProject).toHaveBeenCalledWith(false);
expect(mockProps.setNewTask).toHaveBeenCalledWith({
...mockProps.newTask,
project: '',
});
});

test('updates project when user types in project field', async () => {
mockProps.isOpen = true;
mockProps.isCreatingNewProject = true;
Expand Down
Loading