fix: read URLs from environment variables instead of hardcoded values#403
Merged
its-me-abhishek merged 3 commits intomainfrom Jan 19, 2026
Merged
fix: read URLs from environment variables instead of hardcoded values#403its-me-abhishek merged 3 commits intomainfrom
its-me-abhishek merged 3 commits intomainfrom
Conversation
The URLs.ts file had hardcoded localhost values which prevented the VITE_BACKEND_URL, VITE_FRONTEND_URL, and VITE_CONTAINER_ORIGIN environment variables from being used. This change makes the frontend respect the .env configuration, falling back to localhost defaults for development. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
The ts-jest-mock-import-meta transformer was only mocking import.meta.url but not import.meta.env, causing tests to fail when URLs.ts tries to access import.meta.env.VITE_BACKEND_URL. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Taskwarrior deprecated sync.server.origin in favor of sync.server.url. Updated the setup guide to use the new configuration option name. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
its-me-abhishek
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix frontend to read backend/frontend/container URLs from environment variables instead of using hardcoded localhost values.
Problem
The
URLs.tsfile had hardcoded values:This meant the
VITE_BACKEND_URL,VITE_FRONTEND_URL, andVITE_CONTAINER_ORIGINenvironment variables in.envfiles were completely ignored, making production deployment impossible without code changes.Solution
Use Vite's
import.meta.envto read environment variables at build time, with localhost fallbacks for development:Test plan
🤖 Generated with Claude Code