fix: healthchecks and add standard port sync server access#404
Merged
its-me-abhishek merged 1 commit intomainfrom Jan 19, 2026
Merged
fix: healthchecks and add standard port sync server access#404its-me-abhishek merged 1 commit intomainfrom
its-me-abhishek merged 1 commit intomainfrom
Conversation
- Fix healthchecks to use wget instead of curl (curl not available in Alpine) - Use 127.0.0.1 instead of localhost (resolves correctly in containers) - Fix syncserver healthcheck to use / instead of /health (no /health endpoint) - Add /taskchampion/ path in nginx for sync server on standard port 443 - Update example.frontend.env to use new /taskchampion/ path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
its-me-abhishek
approved these changes
Jan 19, 2026
| VITE_FRONTEND_URL="https://your-domain.com" | ||
| VITE_CONTAINER_ORIGIN="https://your-domain.com:8080/" | ||
| # Use standard port 443 with /taskchampion/ path (recommended) | ||
| VITE_CONTAINER_ORIGIN="https://your-domain.com/taskchampion/" |
Collaborator
There was a problem hiding this comment.
this works fine with the Setup Guide, backend env need not be updated, as Docker connects internally anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wgetinstead ofcurl(curl is not available in Alpine-based containers)127.0.0.1instead oflocalhostin healthchecks (localhost doesn't resolve correctly in some Alpine containers)/instead of/health(taskchampion-sync-server doesn't have a /health endpoint)/taskchampion/path in nginx config for sync server access on standard port 443example.frontend.envto use the new/taskchampion/path as defaultChanges
/taskchampion/location block, marked port 8080 as legacy/taskchampion/path with legacy option documentedBenefits
/taskchampion/pathTest plan
docker compose up -dand verify all containers show healthy status/taskchampion/path🤖 Generated with Claude Code