security: sanitize user input in temp directory names#411
Merged
its-me-abhishek merged 1 commit intomainfrom Jan 19, 2026
Merged
security: sanitize user input in temp directory names#411its-me-abhishek merged 1 commit intomainfrom
its-me-abhishek merged 1 commit intomainfrom
Conversation
Replace direct use of email in temp directory names with a SHA256 hash to prevent directory traversal attacks. - Add utils/sanitize.go with SafeTempDirPrefix() function - Use 8-character hash of email instead of raw email - Update all tw/*.go files to use SafeTempDirPrefix This prevents potential path traversal if user-controlled email contains special characters like path separators. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
its-me-abhishek
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security Issue Addressed
Directory Traversal Risk (Medium) - Previously, user email was used directly in temporary directory names via
os.MkdirTemp("", "taskwarrior-"+email). If the email contained path separators or special characters, it could potentially cause path-related issues.Changes
backend/utils/sanitize.go: New file withSafeTempDirPrefix()functionUpdated files to use
SafeTempDirPrefix:backend/utils/tw/add_task.gobackend/utils/tw/complete_task.gobackend/utils/tw/complete_tasks.gobackend/utils/tw/delete_task.gobackend/utils/tw/delete_tasks.gobackend/utils/tw/edit_task.gobackend/utils/tw/fetch_tasks.gobackend/utils/tw/modify_task.goTest plan
🤖 Generated with Claude Code