docker: add production compose override for localhost-only ports#416
Merged
its-me-abhishek merged 2 commits intomainfrom Jan 21, 2026
Merged
docker: add production compose override for localhost-only ports#416its-me-abhishek merged 2 commits intomainfrom
its-me-abhishek merged 2 commits intomainfrom
Conversation
Creates production/docker-compose.production.yml that binds all service ports to localhost only, allowing nginx to handle external traffic. Changes: - Add docker-compose.production.yml with localhost-only port bindings: - frontend: 127.0.0.1:3000:80 - backend: 127.0.0.1:8000:8000 - syncserver: 127.0.0.1:8081:8080 - Update production/README.md: - Replace manual docker-compose.yml editing with override file usage - Add useful production commands (logs, restart, rebuild) Usage: docker compose -f docker-compose.yml -f production/docker-compose.production.yml up -d This keeps the base docker-compose.yml unchanged for development while providing a versioned production configuration. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Without !override, Docker Compose merges the port arrays, resulting in both public and localhost-only ports being exposed. The !override tag ensures the production ports completely replace the development ones. Note: !reset clears to empty but doesn't apply the new values in some Docker Compose versions. !override works correctly. Requires Docker Compose v2.24.0+ (Compose Spec 2.1) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
f2df3eb to
daf7375
Compare
its-me-abhishek
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
production/docker-compose.production.ymlthat binds all service ports to localhost onlyproduction/README.mdto use the override file instead of manual editingChanges
New file:
production/docker-compose.production.ymlUses
!overrideYAML tag to replace port arrays (not merge them). Requires Docker Compose v2.24.0+.80:80127.0.0.1:3000:808000:8000127.0.0.1:8000:80008080:8080127.0.0.1:8081:8080Usage:
Why
docker-compose.ymlunchanged for developmentTest plan
docker compose -f docker-compose.yml -f production/docker-compose.production.yml configNote: Initially tried
!resetbut it clears arrays without applying new values.!overrideworks correctly.🤖 Generated with Claude Code