feat: use relative URLs for frontend API calls#439
Merged
its-me-abhishek merged 2 commits intomainfrom Jan 31, 2026
Merged
Conversation
Change frontend to use relative URLs instead of hardcoded localhost values. This enables the same Docker image to work in any environment since nginx handles routing to the backend. Changes: - backendURL now uses '/' (relative path) - containerOrigin derived from window.location.origin - Add getWebSocketURL() helper for WebSocket connections - Remove VITE_* env vars from jest config (no longer needed) - Update tests and snapshots This is a prerequisite for automated deployment where images should be environment-agnostic. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Configure Vite's development server to proxy backend routes to localhost:8000, mimicking nginx's routing behavior. This allows relative URLs to work in both local development and production. Routes proxied: /auth, /api, /tasks, /health, /sync, /ws, and all task mutation endpoints. Also proxies /taskchampion to localhost:8080. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/) instead of hardcoded localhost valuesgetWebSocketURL()helper to construct WebSocket URLs from current hostcontainerOrigin) fromwindow.location.originVITE_*environment variables from jest configThis enables the same Docker image to work in any environment since nginx handles routing to the backend. This is a prerequisite for automated deployment where images should be environment-agnostic.
Changes
URLs.tsgetWebSocketURL()helperHomePage.tsxgetWebSocketURL()for WebSocket connectionHomePage.test.tsxgetWebSocketURLto mockjest.config.cjsHero.test.tsx.snap/auth/oauth)Test plan
🤖 Generated with Claude Code