Skip to content

Pyrenew class for Infections with susceptible depletion#733

Open
sbidari wants to merge 3 commits intomainfrom
sb-add-susceptible-depletion
Open

Pyrenew class for Infections with susceptible depletion#733
sbidari wants to merge 3 commits intomainfrom
sb-add-susceptible-depletion

Conversation

@sbidari
Copy link
Contributor

@sbidari sbidari commented Mar 5, 2026

Adds:

  • InfectionsWithSusceptibleDepletion class
  • compute_infections_with_susceptible_depletion() function called by InfectionsWithSusceptibleDepletion class to calculate infections and Rt
  • Adds tests for new functions

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.76%. Comparing base (d265289) to head (7472163).

Files with missing lines Patch % Lines
...ew/latent/infections_with_susceptible_depletion.py 86.20% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   97.95%   97.76%   -0.20%     
==========================================
  Files          51       52       +1     
  Lines        1617     1658      +41     
==========================================
+ Hits         1584     1621      +37     
- Misses         33       37       +4     
Flag Coverage Δ
unittests 97.76% <90.47%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Thank you for your contribution @sbidari 🚀! Your github-pages is ready for download 👉 here 👈!
(The artifact expires on 2026-03-13T23:12:22Z. You can re-generate it by re-running the workflow here.)

@damonbayer
Copy link
Collaborator

I think this contribution needs to be made to the multisignal repo, so that we can test it without rewriting the hew model.

@sbidari
Copy link
Contributor Author

sbidari commented Mar 6, 2026

I think this contribution needs to be made to the multisignal repo, so that we can test it without rewriting the hew model.

I plan to swap InfectionWithFeedback with this new class and not rewrite hew model. If you disagree with this approach, can you explain in more detail what you are proposing.

@sbidari sbidari marked this pull request as ready for review March 6, 2026 23:08
@damonbayer
Copy link
Collaborator

damonbayer commented Mar 7, 2026

@sbidari I am concerned that you won't be able to use this class in PyRenew-multisignal because PyRenew-hew might require an older version of PyRenew. The version we have pinned in PyRenew-multisignal predates the refactor we've been working on the last few months, but I don't know for sure that the refactor breaks PyRenew-hew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants