Template Customizations not working on current tool

[bofstein]

Describe the bug
Attempting to customize a Template is refreshing the Templates page instead of opening that template to customize

To Reproduce

1. Log in as an org admin (I was using a super admin account, but the original report is from an org admin)
2. Navigate to the Templates page and go to the Customizable templates tab
3. Click on any Template that says "Not customized" in the status
4. Observe that the page refreshes and stays on the Template list

Expected behavior
It should open up that Template's customization menu.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

• It's happening on every Template I tried to open.
• If the status is either Unpublished or Published, meaning a Customization has at least been started before, then the Template opens as expected, so the problem seems to be about creating a new Customization.
• I tried to use a URL of one that was working (since it already had a customization) and change the number to be the one I was trying to get to, but that did not work, it just brought me to the edit Template page instead of customization.
• I tried creating a new Template and that seemed to work fine.

[bofstein]

@briri this will of course need to wait until after Thanksgiving but since it seems from my initial testing to be about all Customizations, a core tool component, let's prioritize this before rebuild work next week.

[bofstein]

Some other things I tried just to check if that allowed customization:

• Turning off the Research outputs table
• Adding funder and sample plan links

[briri]

Ok, so this is happening because we show all public published templates for organizations that are designated as a funder in the application (e.g. UCOP is a "funder" and an "organization") but when the user clicks the "Customize" button it does a check to see if the template can be customized.

  def customize?(customizing_org)
    if customizing_org.is_a?(Org) && (**org.funder_only?** || is_default)
      return !Template.unarchived.exists?(customization_of: family_id,
                                          org: customizing_org)
    end
    false
  end

In that check we determine is the org is only a funder not a combined special case. It was really uncommon for orgs to be both funders and regular orgs in the beginning, so I guess it never come up.

We have 2 courses of action I guess:

• Update the page so it stops showing those templates as options to customize
• Update the check and allow the customization to happen. I cannot think of any downstream impacts this could cause, but there may be some.

[bofstein]

Seems to be working so far. I have tested:

• Customizing an existing template from an Org+Funder
• Publishing that customization
• Seeing that customization as a user
• Unpublishing that customization
• Seeing the lack of customization on a new plan
• Customizing a template from a funder alone
• Publishing a new template from an Org+Funder
• Seeing that template appear on the Customizeable list for a another org
• Opening the customization menu for that Template

There's more I could try for hours but the basics I can think of are working as expected so far. I'm good with releasing this.

[bofstein]

Got confirmation from user that it is working now, thank you!