Bug fix for missing Consent Manager background styles on stage and production #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dev, and I also added an override of the cookie-notice colors in a new klaro.scs file, just in case
Collaborator
Author
|
Thanks Brian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a comparison of the
node_modules/klaro-ui/dist/css/klaro-ui.cssfile on my local app and on stage. They are different. It seems that for some reason whenklarois being built for stage and production, it's creating different styles.One thought was that
Dockerfileforstageandproductionhad an oldernodeversion of16, so I updated it to match20on dev's Dockerfile.dev.I also added an override for the
cookie-noticecolors in a newapp/assets/stylesheets/dmptool/_klaro.scssfile, and fixed an issue with our localhoverstyle being applied to the Consent manager buttons.Fixes # 723