Add support for Plug'n Play algorithm#265
Closed
paquiteau wants to merge 9 commits intoCEA-COSMIC:developfrom
Closed
Add support for Plug'n Play algorithm#265paquiteau wants to merge 9 commits intoCEA-COSMIC:developfrom
paquiteau wants to merge 9 commits intoCEA-COSMIC:developfrom
Conversation
This allow to change the step size when calling prox.op method.
Codecov Report
@@ Coverage Diff @@
## develop #265 +/- ##
==========================================
Coverage ? 91.14%
==========================================
Files ? 36
Lines ? 2529
Branches ? 0
==========================================
Hits ? 2305
Misses ? 224
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6 tasks
Contributor
Author
|
In my opinion this PR however good does not produce good results in our application (the hyperparameter tuning is rather picky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Plug'n Play Method, following the notation of 1. Two new algorithms joins the ModOpt Family:
Also, to ease the use of PnP ADMM I also wrote a convertor from Gadient operator to Proximal operator.
Footnotes
https://arxiv.org/pdf/1905.05406.pdf ↩
Add support for ADMM #263 ↩