Fix Gaussian kernel issue#287
Merged
paquiteau merged 5 commits intoCEA-COSMIC:developfrom Mar 15, 2023
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #287 +/- ##
==========================================
Coverage ? 21.81%
==========================================
Files ? 42
Lines ? 2310
Branches ? 0
==========================================
Hits ? 504
Misses ? 1806
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paquiteau
requested changes
Mar 15, 2023
Contributor
paquiteau
left a comment
There was a problem hiding this comment.
Thanks for the PR,
only a docstring update is missing, otherwise, I am good with it.
Contributor
Author
|
Hey @paquiteau, if you are happy with this can you click on the "Approve" button? 🙂 |
paquiteau
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #272
gaussian_kerneland the corresponding test.