Skip to content

Comments

Fix Gaussian kernel issue#287

Merged
paquiteau merged 5 commits intoCEA-COSMIC:developfrom
sfarrens:272-gaussian-kernel-fix
Mar 15, 2023
Merged

Fix Gaussian kernel issue#287
paquiteau merged 5 commits intoCEA-COSMIC:developfrom
sfarrens:272-gaussian-kernel-fix

Conversation

@sfarrens
Copy link
Contributor

@sfarrens sfarrens commented Mar 14, 2023

closes #272

  • Following this Astropy issue, it is no longer possible to return an unnormalised Gaussian kernel. Therefore, I have removed this option from gaussian_kernel and the corresponding test.
  • Following this Scikit-Image issue, a maximum version of the package has been temporarily been set for the tests.

@sfarrens sfarrens added the bug label Mar 14, 2023
@sfarrens sfarrens self-assigned this Mar 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@eeb8d17). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             develop     #287   +/-   ##
==========================================
  Coverage           ?   21.81%           
==========================================
  Files              ?       42           
  Lines              ?     2310           
  Branches           ?        0           
==========================================
  Hits               ?      504           
  Misses             ?     1806           
  Partials           ?        0           
Flag Coverage Δ
unittests 21.81% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfarrens sfarrens requested a review from paquiteau March 15, 2023 11:02
Copy link
Contributor

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR,

only a docstring update is missing, otherwise, I am good with it.

@sfarrens
Copy link
Contributor Author

Hey @paquiteau, if you are happy with this can you click on the "Approve" button? 🙂

@paquiteau paquiteau merged commit 3f8dbee into CEA-COSMIC:develop Mar 15, 2023
@sfarrens sfarrens deleted the 272-gaussian-kernel-fix branch March 15, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants