Skip to content

Comments

fix #290 #292

Merged
paquiteau merged 3 commits intoCEA-COSMIC:developfrom
paquiteau:develop
Sep 25, 2023
Merged

fix #290 #292
paquiteau merged 3 commits intoCEA-COSMIC:developfrom
paquiteau:develop

Conversation

@paquiteau
Copy link
Contributor

Refs: #290

@paquiteau paquiteau requested a review from chaithyagr April 19, 2023 13:45
@paquiteau
Copy link
Contributor Author

So test are passing with current test value if we set data_range=2.0. However, I proposed that we usedata_range=1.0 (see here) , following the documentation of skimage 1, and that we update the test values

Footnotes

  1. https://scikit-image.org/docs/stable/api/skimage.metrics.html#skimage.metrics.structural_similarity

@paquiteau paquiteau merged commit 6f73f7b into CEA-COSMIC:develop Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant