refactor: remove add_args_kwargs.#339
Conversation
This is 1) expensive 2) dangerous 3) source of bug.
|
While this surely looks good to me, I will add Sam to review in case we missed some reason why this should exist. |
|
Hi @paquiteau this makes sense to me, however shouldn't Also, if you want to fully clear out this functionality you will need to additionally make the following changes in
P.S. "consenting adults" 🤣 |
|
The checks for the *args and **kwargs is problematic if you consider all the @Property that have been defined, wrapping internal method (a typical examples are the _cost methods, wrapped in cost). The inspect module is not able to time finding the args and kwargs in the definition (which is what causes the nasty bugs mentioned above. |
|
@paquiteau all good, feel free to merge. :) |
This module brings little value, and mostly nasty bug by adding extra layers.
We are all consenting adults, no need for enforcing *args and **kwargs