chore(husky): remove deprecated bootstrap lines; style: run prettier … by a-elkhiraooui-ciscode · Pull Request #5 · CISCODE-MA/WidgetKit-UI

a-elkhiraooui-ciscode · 2026-02-05T12:13:20Z

…write

Summary

What does this PR change?

Why

Why is this change needed?

Checklist

Added/updated tests (if behavior changed)
npm run lint passes
npm run typecheck passes
npm test passes
npm run build passes
Added a changeset (npx changeset) if this affects consumers

Notes

Anything reviewers should pay attention to?

…write

Copilot

Pull request overview

This PR modernizes the repository's build tooling, testing infrastructure, and code quality setup. It migrates from Vite's library mode to tsup for bundling, introduces comprehensive unit and E2E testing with Vitest and Playwright, and applies consistent code formatting with Prettier.

Changes:

Replaced Vite library build with tsup, producing dual ESM/CJS outputs
Added comprehensive test coverage using Vitest (unit) and Playwright (E2E)
Standardized code formatting across the codebase using Prettier

Reviewed changes

Copilot reviewed 85 out of 96 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
vitest.config.ts	Configured Vitest with jsdom environment, coverage thresholds, and test directories
tsup.config.ts	Added tsup configuration for dual-format builds with proper file extensions
package.json	Updated build scripts, added test/lint/format commands, and reorganized dependencies
src/index.ts	Expanded public API exports to include all components, hooks, and types
src/components/Form/ZodDynamicForm.tsx	Fixed typo 'textt' → 'text' and applied formatting
src/hooks/*.ts	Added new authentication and accessibility hooks with proper TypeScript types
tests/unit/*/.test.tsx	Added comprehensive unit tests for components and hooks
tests/e2e/*/.spec.ts	Added Playwright E2E tests for examples app
.husky/pre-commit	Updated to run format, lint, typecheck, and test
examples/	Added examples app with vite config for component demonstration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T12:14:17Z

src/hooks/usePasswordReset.tsx

+  const [success, setSuccess] = useState<boolean>(false);
+
+  function update<K extends keyof PasswordResetInput>(key: K, value: PasswordResetInput[K]) {
+    setValues((v: PasswordResetInput) => ({ ...v, [key]: value }));


The type annotation on the updater function parameter v: PasswordResetInput is redundant since TypeScript infers it from the state type. Remove it for consistency with the .ts version in the same directory.

Suggested change

setValues((v: PasswordResetInput) => ({ ...v, [key]: value }));

setValues((v) => ({ ...v, [key]: value }));

Copilot · 2026-02-05T12:14:18Z

src/hooks/useLogin.tsx

+  const [result, setResult] = useState<LoginResult<TUser> | null>(null);
+
+  function update<K extends keyof LoginCredentials>(key: K, value: LoginCredentials[K]) {
+    setValues((v: LoginCredentials) => ({ ...v, [key]: value }));


The type annotation on the updater function parameter v: LoginCredentials is redundant since TypeScript infers it from the state type. Remove it for consistency with the .ts version in the same directory.

Suggested change

setValues((v: LoginCredentials) => ({ ...v, [key]: value }));

setValues((v) => ({ ...v, [key]: value }));

Copilot · 2026-02-05T12:14:18Z

src/components/Breadcrumbs/Breadcrumb.tsx

@@ -1,19 +1,25 @@
 import React from 'react';
-import { Link } from 'react-router';
+import { Link } from 'react-router-dom';


The import changed from 'react-router' to 'react-router-dom', but the test file src/components/Breadcrumbs/Breadcrumb.test.tsx still mocks 'react-router' instead of 'react-router-dom'. This inconsistency should be resolved.

Copilot · 2026-02-05T12:14:19Z

examples/App.tsx

+  });
+  const fields: FieldConfigDynamicForm[] = [
+    { key: 'name', label: 'Name', type: 'text' },
+    { key: 'email', label: 'Email', type: 'email' },


Field type 'email' is not a valid FieldType according to the model definition in src/models/FieldConfigDynamicForm.ts. The valid types are: 'text', 'number', 'textarea', 'select', 'checkbox', 'multiSelect', 'custom'. Use 'text' instead of 'email'.

Suggested change

{ key: 'email', label: 'Email', type: 'email' },

{ key: 'email', label: 'Email', type: 'text' },

Copilot · 2026-02-05T12:14:19Z

src/hooks/useKeyboardNavigation.ts

+  }, [container, selector, initialIndex]);
+}
+
+export default undefined;


Exporting undefined as the default export serves no purpose. Remove this line or export the function as default if it's intended to be the primary export.

Suggested change

export default undefined;

export default useKeyboardNavigation;

Copilot · 2026-02-05T12:14:19Z

src/hooks/useA11y.ts

+
+export default undefined;


Exporting undefined as the default export serves no purpose. Remove this line.

Suggested change

export default undefined;

Copilot

Pull request overview

Copilot reviewed 86 out of 97 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T12:29:19Z

src/components/Form/ZodDynamicForm.tsx

@@ -250,7 +242,7 @@ export default function ControlledZodDynamicForm({
 //Show erros validation


Corrected spelling of 'erros' to 'errors' in comment.

Suggested change

//Show erros validation

// Show errors validation

Copilot · 2026-02-05T12:29:20Z

src/components/Breadcrumbs/Breadcrumb.tsx

@@ -1,19 +1,25 @@
 import React from 'react';
-import { Link } from 'react-router';
+import { Link } from 'react-router-dom';


The import changed from 'react-router' to 'react-router-dom', which is correct for client-side routing. However, verify that 'react-router-dom' is listed in peerDependencies (already confirmed in package.json line 47), and ensure all other files using 'react-router' imports are also updated consistently.

Copilot · 2026-02-05T12:29:20Z

src/hooks/useA11y.ts

+
+export default undefined;


Exporting undefined as default is unusual and may confuse consumers. Since the hooks are already exported as named exports, consider removing the default export entirely.

Suggested change

export default undefined;

Copilot · 2026-02-05T12:29:20Z

.husky/pre-commit

+npm run format:write
+npm run lint
+npm run typecheck
+npm test


Running all these commands sequentially in pre-commit can be slow and frustrate developers. Consider using a tool like lint-staged to only check staged files, or move some checks (like full test suite) to pre-push or CI.

Suggested change

npm test

Copilot · 2026-02-05T12:29:20Z

src/components/Table/TableDataCustomBase.tsx

-                    {columns.map(col => (
-                      <th key={String(col.key)} className="px-4 py-3">{col.title}</th>
+                    {columns.map((col, i) => (
+                      <th key={i} className="px-4 py-3">


Using array index as key is not recommended when the column order might change. Since columns have a key property, consider using String(col.key) or a stable identifier as the key instead of the index.

Suggested change

<th key={i} className="px-4 py-3">

<th key={String(col.key)} className="px-4 py-3">

…o master

…e timeouts

Zaiidmo

It would be appreciated if the workflows directory stays the same as it is, as well as husky's pre-commit and pre-push configurations

Zaiidmo · 2026-02-05T12:45:57Z

Unaccepted changes in the operations files !
#Closing the PR

Copilot

Pull request overview

Copilot reviewed 87 out of 98 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T12:46:14Z

src/components/Breadcrumbs/Breadcrumb.test.tsx

+  useT: () => (key: string, vars?: any) => (typeof key === 'string' ? key : 't'),
+}));
+
+vi.mock('react-router', () => ({


Mock uses 'react-router' but the component now imports from 'react-router-dom'. Update the mock to match the actual import source.

Suggested change

vi.mock('react-router', () => ({

vi.mock('react-router-dom', () => ({

Copilot · 2026-02-05T12:46:14Z

src/hooks/useKeyboardNavigation.ts

+
+export default undefined;


Exporting undefined as default is unnecessary and confusing. Since the file exports a named function, remove the default export entirely.

Suggested change

export default undefined;

chore(husky): remove deprecated bootstrap lines; style: run prettier …

31f6ffc

…write

a-elkhiraooui-ciscode requested review from a team and Copilot February 5, 2026 12:13

Copilot AI reviewed Feb 5, 2026

View reviewed changes

a-elkhiraooui-ciscode added 2 commits February 5, 2026 13:18

chore: bump version to 1.0.2

f062688

ci: run workflows on PRs to master

6ab6197

Copilot AI review requested due to automatic review settings February 5, 2026 12:28

Copilot AI reviewed Feb 5, 2026

View reviewed changes

a-elkhiraooui-ciscode added 2 commits February 5, 2026 13:40

ci(e2e): strict port + no server reuse; enable release check on PRs t…

ec809d2

…o master

ci(e2e): bind dev server to 127.0.0.1; align Playwright URLs; increas…

46e806b

…e timeouts

Zaiidmo reviewed Feb 5, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 5, 2026 12:45

Zaiidmo closed this Feb 5, 2026

Copilot AI reviewed Feb 5, 2026

View reviewed changes

	setValues((v: PasswordResetInput) => ({ ...v, [key]: value }));
	setValues((v) => ({ ...v, [key]: value }));

	setValues((v: LoginCredentials) => ({ ...v, [key]: value }));
	setValues((v) => ({ ...v, [key]: value }));

	{ key: 'email', label: 'Email', type: 'email' },
	{ key: 'email', label: 'Email', type: 'text' },

	export default undefined;
	export default useKeyboardNavigation;

		@@ -250,7 +242,7 @@ export default function ControlledZodDynamicForm({
		//Show erros validation

	<th key={i} className="px-4 py-3">
	<th key={String(col.key)} className="px-4 py-3">

	vi.mock('react-router', () => ({
	vi.mock('react-router-dom', () => ({

Conversation

a-elkhiraooui-ciscode commented Feb 5, 2026

Summary

Why

Checklist

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Zaiidmo left a comment

Choose a reason for hiding this comment

Uh oh!

Zaiidmo commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants