Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 28 28
Lines 1608 1608
=======================================
Hits 1554 1554
Misses 54 54 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jmafoster1
reviewed
Jan 6, 2026
jmafoster1
reviewed
Jan 6, 2026
jmafoster1
approved these changes
Jan 6, 2026
Collaborator
jmafoster1
left a comment
There was a problem hiding this comment.
I fixed a couple of little typos/inconsistencies, but otherwise looks good.
Collaborator
Author
|
@jmafoster1 Thanks Michael. There's a quick bug in the model definition - I'm just trying to debug it. I'll fix that then I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the DAFNI containerization and workflow for the Causal Testing Framework. The main changes include a more flexible and automated entrypoint script, enhanced configuration via environment variables, improved documentation, and some workflow and metadata updates.
Containerization and Workflow Automation:
entrypoint.shscript that auto-detects whether to generate or test causal tests based on the presence of thecausal_tests.jsonfile, or allows explicit override via theEXECUTION_MODEenvironment variable. All command-line options are now configurable through the.envfile. (dafni/entrypoint.sh,dafni/Dockerfile,dafni/.env,dafni/README.md) [1] [2] [3] [4]Configuration and Environment:
.envfile, making the Docker image and workflow more flexible and easier to maintain. (dafni/.env,dafni/README.md) [1] [2]dafni/Dockerfile) [1] [2]Documentation Improvements:
README.mdto clarify directory structure, configuration, workflow, and usage of the.envfile. Also updated the mainREADME.mdwith contact information and corrected example command-line arguments to use the new flag names. (dafni/README.md,README.md) [1] [2] [3]Workflow and CI Adjustments:
.github/workflows/publish-to-dafni.yaml) [1] [2] [3]