Update Spock to stable 2.3-groovy-4.0 and Groovy to 4.0.24#5
Open
devin-ai-integration[bot] wants to merge 1 commit intodevelop-7.0.xfrom
Open
Update Spock to stable 2.3-groovy-4.0 and Groovy to 4.0.24#5devin-ai-integration[bot] wants to merge 1 commit intodevelop-7.0.xfrom
devin-ai-integration[bot] wants to merge 1 commit intodevelop-7.0.xfrom
Conversation
- Update spock.core.version from 2.4-M4-groovy-4.0 to 2.3-groovy-4.0 - Update spock.spring.version from 2.4-M4-groovy-4.0 to 2.3-groovy-4.0 - Update groovy.version from 4.0.20 to 4.0.24 - Spock 2.3-groovy-4.0 is the latest stable Spock 2.x release (no stable 2.4 exists yet) - Verified test-compile succeeds for common and admin/broadleaf-open-admin-platform modules Co-Authored-By: Arjun Mishra <arjunsaxmishra@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Replaces the Spock milestone release (
2.4-M4-groovy-4.0) with the latest stable Spock 2.x release (2.3-groovy-4.0) and bumps Groovy from4.0.20to4.0.24. No stable Spock 2.4 release exists on Maven Central yet, so2.3-groovy-4.0is the correct target.Labels: Enhancement, Status: ready-for-code-review
Changes
In the root
pom.xmlproperties:spock.core.version2.4-M4-groovy-4.02.3-groovy-4.0spock.spring.version2.4-M4-groovy-4.02.3-groovy-4.0groovy.version4.0.204.0.24All module POMs (
common,admin/broadleaf-open-admin-platform,core/broadleaf-framework,integration,admin/broadleaf-admin-functional-tests) inherit these versions from the root POM'sdependencyManagement—no child POM changes are needed.mvn test-compilewas verified successfully forcommonandadmin/broadleaf-open-admin-platform(the two modules with Spock test sources).Human Review Checklist
spock-spring— verify it also compiles/passes tests with 2.3.Link to Devin session: https://app.devin.ai/sessions/8a4b67f490ce4799b8aed23aad1d54a9
Requested by: @Colhodm